Do not install tests in site-packages#139
Merged
rayluo merged 1 commit intoAzureAD:devfrom Mar 14, 2025
Merged
Conversation
rayluo
approved these changes
Mar 14, 2025
Contributor
|
Version 1.3.1 is shipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude
testsfromfind_packages().Before this PR,
Obviously, we don’t want to install the tests as a top-level
testspackage. This is wrong and risks confusion and conflicts in a virtualenv, and it is even worse in a system-wide distribution package.This appears to be a regression in 1.3.0, accidentally triggered by the addition of
tests/__init__.pyin 4b90cc8.I can also reproduce the problem in a git checkout, working on
dev(version numbers are 1.2.0 because #138 hasn’t been merged yet):After this PR, the tests are no longer included in the wheel: